WIP: YPE-641 highlight UI #104
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directory is used by the OpenCode tool and should not be committed to the repository.
This commit introduces logic to wrap verse content within `yv-v` elements. This change facilitates easier CSS targeting for verse-specific styling, such as highlighting. The implementation handles cases where verses span multiple paragraphs by duplicating the `yv-v` wrapper as per the Bible.com pattern. It also ensures that verse labels are preserved within these new wrappers and that header elements are not erroneously included.
The extractNotesFromHtml function has been refactored into extractNotesFromWrappedHtml. This new function assumes that verse content has already been wrapped in .yv-v[v] elements by wrapVerseContent. This change simplifies the footnote extraction process by leveraging the existing verse wrapping and making the logic more straightforward. It also ensures footnotes are correctly associated with their respective verses, even when verses span multiple paragraphs.
Insert the footnote placeholder as a sibling after the last verse wrapper, rather than as a child of the last verse wrapper. This ensures correct DOM structure and prevents potential rendering issues.
This commit introduces the ability to select individual verses within the Verse and BibleTextView components. Key changes include: - Added `selectedVerses` and `onVerseSelect` props to `VerseHtml`, `Verse`, and `BibleTextView` components. - Implemented click handlers in `HtmlWithNotes` to manage verse selection and deselection. - Added styling for selected verses in `bible-reader.css`. - Introduced a new `VerseSelection` story to demonstrate the new functionality.
|
cameronapak
changed the base branch from
main
to
cam/YPE-641-precursor-transform-html-for-highlights
cameronapak
force-pushed
the
cam/YPE-641-precursor-transform-html-for-highlights
branch
from
9b15534 to
798894e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Relies on #103
Ticket: https://lifechurch.atlassian.net/browse/YPE-641
Related to: https://lifechurch.atlassian.net/browse/YPE-642