Skip to content

Conversation

@rivanuff
Copy link

@rivanuff rivanuff commented Jul 2, 2025

See #54

@github-actions
Copy link

github-actions bot commented Jul 2, 2025

Coverage report for commit: 49975ce
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 78.6%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ███░░░░░░░░░░░░░░░░░░░░ │  7.1%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.3%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 13.53% | Methods: 9.09%
FilesLinesMethodsBranches
src/Attributes
   Meta.php--100.00%
   MetaPrefix.php--100.00%
   TaxonomyPrefix.php--100.00%
   Terms.php--100.00%
src/Contracts
   PostDataInterface.php100.00%100.00%100.00%
src/Enums
   PostStatus.php--100.00%
src
   ImageData.php--100.00%
   PostData.php18.26%8.70%100.00%
   TermData.php--100.00%
   UserData.php--100.00%
src/Mappers
   PostPrefixMapper.php--100.00%
   UserPrefixMapper.php--100.00%
src/Normalizers
   WPPostNormalizer.php--100.00%
src/Providers
   DataServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@SimonvanWijhe
Copy link
Member

SimonvanWijhe commented Jul 2, 2025

The url() method is currently just a convenience helper, allowing you to use $post->url() instead of get_permalink($post->id()).

From my perspective, the use of is_post_type_viewable() here seems like an attempt to work around a limitation in get_permalink() rather than something that belongs in the url() method itself.

@rivanuff rivanuff closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PostData->url() returned (oude) URL bij CPT's terwijl publicly_queryable op false staat

3 participants