Skip to content

(feat): utility functions for hierarchical post types #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ictbeheer merged 2 commits into from
Jul 8, 2025
Merged

(feat): utility functions for hierarchical post types #48

ictbeheer merged 2 commits into from
Jul 8, 2025

Conversation

@ictbeheer
Copy link
Contributor

@ictbeheer ictbeheer commented Jun 12, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 12, 2025 •
edited
Loading

Coverage report for commit: 8aa2da7
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 78.6%
  10% │ ███░░░░░░░░░░░░░░░░░░░░ │  7.1%
  20% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.3%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution
Summary - Lines: 11.71% | Methods: 6.12%
FilesLinesMethodsBranches
src/Attributes
   Meta.php--100.00%
   MetaPrefix.php--100.00%
   TaxonomyPrefix.php--100.00%
   Terms.php--100.00%
src/Contracts
   PostDataInterface.php100.00%100.00%100.00%
src/Enums
   PostStatus.php--100.00%
src
   ImageData.php--100.00%
   PostData.php14.62%3.57%100.00%
   TermData.php--100.00%
   UserData.php--100.00%
src/Mappers
   PostPrefixMapper.php--100.00%
   UserPrefixMapper.php--100.00%
src/Normalizers
   WPPostNormalizer.php--100.00%
src/Providers
   DataServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

YvetteNikolov
YvetteNikolov reviewed Jun 12, 2025
View reviewed changes
@YvetteNikolov
Copy link
Contributor

YvetteNikolov commented Jun 12, 2025

Het enige wat ik nu nog mis, is een functie die checkt of de post een top-level post is. Dus geen children, en óók geen parent.

Bij een "Projecten" CPT heb je bijv. "Deelprojecten", maar ook "Deel-deelprojecten". Hier zou een $post->isTopLevelParent()of isRootParent() chill zijn.

mvdhoek1
mvdhoek1 approved these changes Jun 13, 2025
View reviewed changes
YvetteNikolov
YvetteNikolov reviewed Jun 13, 2025
View reviewed changes
YvetteNikolov
YvetteNikolov reviewed Jun 13, 2025
View reviewed changes
src/PostData.php
return null;
}

return static::fromPost($parent);
Copy link
Contributor

@YvetteNikolov YvetteNikolov Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat als dit een ander post type is?

@ictbeheer ictbeheer force-pushed the feat/hierarchical-cpt-functions branch from a66da4c to b5557c2 Compare June 13, 2025 08:36
SimonvanWijhe
SimonvanWijhe approved these changes Jun 17, 2025
View reviewed changes
@YvetteNikolov YvetteNikolov mentioned this pull request Jun 20, 2025
Merged
@ictbeheer ictbeheer merged commit eefbe38 into main Jul 8, 2025
5 checks passed
@ictbeheer ictbeheer deleted the feat/hierarchical-cpt-functions branch July 8, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YvetteNikolov YvetteNikolov YvetteNikolov left review comments

@mvdhoek1 mvdhoek1 mvdhoek1 approved these changes

@WybeBosch WybeBosch WybeBosch approved these changes

@SimonvanWijhe SimonvanWijhe SimonvanWijhe approved these changes

@dtakken dtakken Awaiting requested review from dtakken dtakken is a code owner automatically assigned from yardinternet/wordpress-backend

@robertbossaert robertbossaert Awaiting requested review from robertbossaert robertbossaert is a code owner automatically assigned from yardinternet/wordpress-backend

@hnccox-yard hnccox-yard Awaiting requested review from hnccox-yard hnccox-yard is a code owner automatically assigned from yardinternet/wordpress-backend

@Rovasch Rovasch Awaiting requested review from Rovasch Rovasch is a code owner automatically assigned from yardinternet/wordpress-backend

@Yannicvanveen Yannicvanveen Awaiting requested review from Yannicvanveen Yannicvanveen was automatically assigned from yardinternet/wordpress-frontend

@laravdiemen laravdiemen Awaiting requested review from laravdiemen laravdiemen was automatically assigned from yardinternet/wordpress-frontend

@FreakyWizard FreakyWizard Awaiting requested review from FreakyWizard FreakyWizard was automatically assigned from yardinternet/wordpress-frontend

@LailaButrah LailaButrah Awaiting requested review from LailaButrah LailaButrah was automatically assigned from yardinternet/wordpress-frontend

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ictbeheer @YvetteNikolov @mvdhoek1 @WybeBosch @SimonvanWijhe