Skip to content

Conversation

@SimonvanWijhe
Copy link
Member

Nullable id, date and modified can be useful when using PostData for data validation before saving a post to the database.

defaultDateFormat() can be useful in child classes of PostData

  • (feat): nullable PostData attributes
  • (feat): protected defaultDateFormat

@SimonvanWijhe SimonvanWijhe requested review from a team, dtakken, hnccox-yard, ictbeheer, mvdhoek1 and robertbossaert and removed request for a team February 24, 2025 14:05
@github-actions
Copy link

github-actions bot commented Feb 24, 2025

Coverage report for commit: ff35eb7
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 78.6%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ███░░░░░░░░░░░░░░░░░░░░ │  7.1%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.3%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 13.27% | Methods: 6.82%
FilesLinesMethodsBranches
src/Attributes
   Meta.php--100.00%
   MetaPrefix.php--100.00%
   TaxonomyPrefix.php--100.00%
   Terms.php--100.00%
src/Contracts
   PostDataInterface.php100.00%100.00%100.00%
src/Enums
   PostStatus.php--100.00%
src
   ImageData.php--100.00%
   PostData.php18.27%4.35%100.00%
   TermData.php--100.00%
   UserData.php--100.00%
src/Mappers
   PostPrefixMapper.php--100.00%
   UserPrefixMapper.php--100.00%
src/Normalizers
   WPPostNormalizer.php--100.00%
src/Providers
   DataServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

@github-actions
Copy link

Coverage report for commit: 5fb355d
File: coverage.xml

Cover ┌─────────────────────────┐ Freq.
   0% │ ███████████████████████ │ 78.6%
  10% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  20% │ ███░░░░░░░░░░░░░░░░░░░░ │  7.1%
  30% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  40% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  50% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  60% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  70% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  80% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
  90% │ ░░░░░░░░░░░░░░░░░░░░░░░ │  0.0%
 100% │ █████░░░░░░░░░░░░░░░░░░ │ 14.3%
      └─────────────────────────┘
 *Legend:* █ = Current Distribution 
Summary - Lines: 13.30% | Methods: 9.09%
FilesLinesMethodsBranches
src/Attributes
   Meta.php--100.00%
   MetaPrefix.php--100.00%
   TaxonomyPrefix.php--100.00%
   Terms.php--100.00%
src/Contracts
   PostDataInterface.php100.00%100.00%100.00%
src/Enums
   PostStatus.php--100.00%
src
   ImageData.php--100.00%
   PostData.php18.75%8.70%100.00%
   TermData.php--100.00%
   UserData.php--100.00%
src/Mappers
   PostPrefixMapper.php--100.00%
   UserPrefixMapper.php--100.00%
src/Normalizers
   WPPostNormalizer.php--100.00%
src/Providers
   DataServiceProvider.php100.00%100.00%100.00%

🤖 comment via lucassabreu/comment-coverage-clover

Copy link

@mvdhoek1 mvdhoek1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waar kwam je de fout tegen eigenlijk?

@github-actions
Copy link

Composer package changes
Prod Packages Operation Base Target
phpstan/phpdoc-parser Upgraded 2.0.1 2.1.0
Dev Packages Operation Base Target
friendsofphp/php-cs-fixer Upgraded v3.68.3 v3.70.0
larastan/larastan Upgraded v2.9.12 v2.9.14
laravel/tinker Upgraded v2.10.0 v2.10.1
myclabs/deep-copy Upgraded 1.12.1 1.13.0
orchestra/sidekick New - v1.0.3
orchestra/testbench Upgraded v8.31.0 v8.33.0
orchestra/testbench-core Upgraded v8.32.1 v8.34.0
orchestra/workbench Upgraded v8.17.1 v8.17.2
php-stubs/wordpress-stubs Upgraded v6.7.1 v6.7.2
phpmyadmin/sql-parser Upgraded 5.10.3 5.11.0
phpstan/phpstan Upgraded 1.12.16 1.12.19
symfony/yaml Upgraded v6.4.13 v6.4.18

@SimonvanWijhe
Copy link
Member Author

Waar kwam je de fout tegen eigenlijk?

Geen fout. Maar ik gebruik het PostData object om externe data te valideren en maak er daarna een post mee aan in de database.

@SimonvanWijhe SimonvanWijhe merged commit 7a0cc2f into main Mar 10, 2025
6 checks passed
@SimonvanWijhe SimonvanWijhe deleted the develop branch March 10, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants