fix: append script tags within <form> element so ajax refreshes html #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivanuff
requested review from
a team,
Rovasch,
SimonvanWijhe,
YvetteNikolov,
dtakken,
hnccox-yard,
ictbeheer and
mvdhoek1
and removed request for
a team
YvetteNikolov
approved these changes
Jan 27, 2026
mvdhoek1
approved these changes
Jan 27, 2026
ictbeheer
reviewed
Jan 28, 2026
| $pattern = '/\son([a-z]*)\s*=\s*([\'"])((?>\\\\\2|[^\2])*?)\2/m'; | ||
| $scriptTags = []; | ||
| { | ||
| $pattern = '/\son([a-z]*)\s*=\s*([\'"])((?>\\\\\2|[^\2])*?)\2/m'; |
Contributor
There was a problem hiding this comment.
Staat los van deze fix, maar als je in een regex groepen een naam geeft is het duidelijker wat $matches[x] is.
$pattern = '/\son(?P<event>[a-z]*)\s*=\s*([\'"])(?P<handler>(?>\\\\\2|[^\2])*?)\2/m';Dan kan je $matches['handler'] gebruiken ipv $matches[3]
SimonvanWijhe
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.