Add bottomLayoutGuide to support iPhone 10 home button#38
Open
xamoom-raphael wants to merge 3 commits intoyannickl:masterfrom
Open
Add bottomLayoutGuide to support iPhone 10 home button#38xamoom-raphael wants to merge 3 commits intoyannickl:masterfrom
xamoom-raphael wants to merge 3 commits intoyannickl:masterfrom
Conversation
Add the bottomLayoutGuide to the visual constraint to have the Cancel-Button adjust to the new home button on iPhone 10. Also add a LaunchScreen because without it wont use the whole iPhone 10 screen and have black bars on top and bottom.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
- Coverage 5.42% 5.39% -0.03%
=========================================
Files 9 9
Lines 387 389 +2
Branches 26 26
=========================================
Hits 21 21
- Misses 364 366 +2
Partials 2 2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the bottomLayoutGuide to the visual constraint to have the Cancel-Button adjust to the new home button on iPhone 10.
Also add a LaunchScreen because without it wont use the whole iPhone 10 screen and have black bars on top and bottom.
Sorry for the strange empty rows, the real change starts in QRCodeReaderViewController.m at line 255.