-
Notifications
You must be signed in to change notification settings - Fork 80
Add support for GitHub Enterprise URLs in manifest #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ | |
| }, | ||
| "content_scripts": [ | ||
| { | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*"], | ||
| "matches": ["https://github.com/*", "https://gist.github.com/*", "https://*.ghe.com/*"], | ||
|
||
| "css": ["wide-github.css"], | ||
| "js": ["wide-github-toggle.js"] | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added match pattern only covers subdomains of
ghe.com(and notghe.comitself), and it likely won’t satisfy the stated goal of “GitHub Enterprise URLs” since most Enterprise Server instances run on arbitrary custom hostnames (e.g.,github.company.com). Consider either adding an explicit pattern forhttps://ghe.com/*(if desired) and/or switching to a configurable/optional host permission + dynamic script injection approach so users can add their own Enterprise domain(s).