Fixed Cuore.State spec failures and added test for local storage state persistence.#3
Open
trikitrok wants to merge 11 commits intoxaviuzz:masterfrom
trikitrok:master
Open
Fixed Cuore.State spec failures and added test for local storage state persistence.#3trikitrok wants to merge 11 commits intoxaviuzz:masterfrom trikitrok:master
trikitrok wants to merge 11 commits intoxaviuzz:masterfrom
trikitrok:master
Conversation
Collaborator
trikitrok
commented
Jun 25, 2015
trikitrok
commented
- Made explicit the dependency of Cuore.State on a persister object to preserve previous Cuore.State behavior (without persistence) using a default null persister and implemented a local storage persister that can be injected into Cuore.State.
- Changed Cuore.Page so that a state persister can be injected through its constructor and initialized FirstTime in main.js with the local storage persister.
…n Cuore.State class which probably have to do with changes related to including local storage
…preserve previous Cuore.State behavior (without persistence) using a default null persister and implemented a local storage persister that can be injected into Cuore.State
…at private methods were called
….Registry.Spec and the used parts of Cuore.Mocks and Cuore.Matchers work with current Jasmine version Also eliminated a couple of no longer necessary tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.