CategoryEditsRepo: use linktarget tables and improve performance #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Toolforge replicas still supported the categorylinks.cl_to column but it was incredibly slow. This commit switches to using the new linktarget table and the foreign key categorylinks.cl_target_id In my testing, performance is best when querying for the link target IDs first, even though the query plan looks worse than JOINing on linktarget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Toolforge replicas still supported the categorylinks.cl_to column but it was incredibly slow. This commit switches to using the new linktarget table and the foreign key categorylinks.cl_target_id
In my testing, performance is best when querying for the link target IDs first, even though the query plan looks worse than JOINing on linktarget.