Skip to content

Pin faraday >= 1.10.5 for security fix#689

Open
mokagio wants to merge 1 commit intotrunkfrom
pin-faraday-1.10.5
Open

Pin faraday >= 1.10.5 for security fix#689
mokagio wants to merge 1 commit intotrunkfrom
pin-faraday-1.10.5

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 13, 2026

Summary

  • Pin faraday to >= 1.10.5 to address security vulnerability
  • Faraday 1.10.5 backports the fix from 2.x to the 1.x line

Test plan

  • CI passes with updated dependency

🤖 Generated with Claude Code

Posted by Claude (Opus 4.6) on behalf of @mokagio with approval.

---

Generated with the help of Claude Code, https://code.claude.com

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 13, 2026

1 Warning
⚠️ Please add an entry in the CHANGELOG.md file to describe the changes made by this PR

Generated by 🚫 Danger

@AliSoftware
Copy link
Contributor

I tried to @copilot address the PR comment from Danger but apparently GitHub doesn't give me the option to ping Copilot (I don't have a Copilot subscription… but I thought many of us don't either and that it included org-wise instead?)

So maybe we'll have to address the missing CHANGELOG.md entry manually… or better yet, iterate on your agent's instructions to tell it to consider doing that for repos that have a manually-maintained CHANGELOG.md, and also tell it to check the Dangerfile for rules and account for them when creating the PR…

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good but as Danger mentions we need a CHANGELOG.md.

I'll leave this as a comment to avoid accidental automerge and instead let you use this as an experiment/testbed to improve your agent's instructions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants