Add iOS Preload Tests #253
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
add/preload-list-tests
branch
3 times, most recently
from
8876355 to
bee4474
Compare
jkmassel
force-pushed
the
add/preload-list
branch
from
71f68fa to
c8d4f11
Compare
jkmassel
force-pushed
the
add/preload-list-tests
branch
2 times, most recently
from
b466e2a to
99ce8f9
Compare
dcalhoun
reviewed
Dec 10, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Thank you for the thorough test coverage!
I skimmed the test names, and a few dozen test implementations. The tests look good to me.
Some of the more granular tests seem less valuable (e.g., Foundation extensions). Hopefully their long-term value exceeds any maintenance cost—presumably we won't change these much and generative AI should make changes easier. I'm not opposed to keeping them, but we could consider reduction or consolidation if deemed worthwhile.
ios/Tests/GutenbergKitTests/Resources/editor-asset-manifest-test-case-1.json
Show resolved
Hide resolved
jkmassel
force-pushed
the
add/preload-list-tests
branch
from
99ce8f9 to
543e9e1
Compare
jkmassel
force-pushed
the
add/preload-list-tests
branch
from
543e9e1 to
64284af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the tests for #250, split out because there's a lot of code.