Conversation
There was a problem hiding this comment.
Pull request overview
Adds TCP Selective Acknowledgment (SACK) support to wolfIP’s TCP implementation, including option negotiation, SACK block generation, basic out-of-order (OOO) receive handling, and SACK-informed early retransmit behavior.
Changes:
- Add TCP option parsing/building for SACK Permitted and SACK blocks, plus related TCP socket state.
- Track small OOO receive cache to generate SACK blocks and promote data when holes close.
- Add unit tests covering SACK advertisement/negotiation, OOO receive behavior, and SACK-driven early retransmit; update README protocol table.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/wolfip.c | Implements SACK option parsing/building, OOO receive cache + SACK reporting, and SACK-informed retransmit decisions. |
| src/test/unit/unit.c | Adds unit tests validating SACK negotiation, ACK/SACK option emission, OOO handling, and retransmit behavior. |
| README.md | Updates the protocol/features table to mention SACK and related TCP capabilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Skip retransmitting partially-acknowledged packets, as it could cause side effects on in-flight calculation + unnecessary repeated retransmissions.
gasbytes
left a comment
gasbytes
left a comment
There was a problem hiding this comment.
lgtm, only one thing might be to add comments on top of the newly added funcs (e.g.: tcp_consume_ooo, tcp_store_ooo_segment etc...), for better docs
As requested by reviewer
2 participants
No description provided.