fix (wh_message): Standardize Message Translation and Enhance Safety #236
+37
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
kaabia
force-pushed
the
fix/translate-macros-and-stray-tokens
branch
from
3bcb435 to
3e1df6e
Compare
bigbrett
approved these changes
Dec 12, 2025
Contributor
|
@kaabia looks like CI is failing. Could you please rebase this ontop of the latest? I believe that will fix the CI falure. |
- Replace wh_Translate32/64 usages with WH_T32/WH_T64/WH_T64 macros in message translation files. - Use WH_NVM_LABEL_LEN for label memcpy to avoid sizeof mismatch. - Make internal DMA translation helpers static and add NULL checks. - Change hashType from int to uint32_t in wh_message_crypto.h for consistent (de)serialization. Signed-off-by: Badr Bacem KAABIA <badrbacemkaabia@gmail.com>
kaabia
force-pushed
the
fix/translate-macros-and-stray-tokens
branch
from
3e1df6e to
4828814
Compare
Contributor
Author
Sorry for the late respond. |
bigbrett
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request standardizes message field translation using internal macros and implements several fixes to enhance message handling safety and consistency across communication and crypto message files;
Key changes: