Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Jan 2, 2026

TaskWPB-21193 [Web] Calling - Users have to navigate backwards and in some cases no event is triggered

Pull Request

Summary

Enhance accessibility in modal components on call view.

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 103
  • Failed: 8
  • Skipped: 11
  • 🔁 Flaky: 7
  • 📊 Total: 129
  • Total Runtime: 379.1s (~ 6 min 19 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to see collapsed view when app is narrow (tags: TC-48, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 2 flaky)
  • ⚠️ Authentication > I want to be asked to share telemetry data when I log in (tags: TC-8780, regression)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/conversationManagement-TC-8636.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversation Management (tags: TC-8636, crit-flow-web)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)
specs/LoginSpecs/login.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Verify you can sign in by email (tags: TC-3461, regression)
specs/Reply/reply.spec.ts (❌ 1 failed, ⚠️ 1 flaky)
  • ❌ Reply > I should not be able to send a reply after I got removed from the conversation (tags: TC-3014, regression)
  • ⚠️ Reply > I should not be able to reply to a ping (tags: TC-8038, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ set globally in group conversation > I want to set a global group conversation timer (tags: TC-3715, regression)

@zskhan zskhan force-pushed the feat/accessibility-on-calling-view branch from 44d16f6 to 99f300a Compare January 2, 2026 09:46
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

❌ Patch coverage is 24.74227% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.54%. Comparing base (5a6a60b) to head (574446d).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19955      +/-   ##
==========================================
- Coverage   44.62%   44.54%   -0.08%     
==========================================
  Files        1311     1312       +1     
  Lines       33031    33101      +70     
  Branches     7317     7340      +23     
==========================================
+ Hits        14739    14746       +7     
- Misses      16540    16601      +61     
- Partials     1752     1754       +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zskhan zskhan enabled auto-merge (squash) January 5, 2026 09:12
@zskhan zskhan disabled auto-merge January 5, 2026 09:12
@zskhan zskhan enabled auto-merge (squash) January 5, 2026 09:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@zskhan zskhan merged commit be148ef into dev Jan 5, 2026
39 of 46 checks passed
@zskhan zskhan deleted the feat/accessibility-on-calling-view branch January 5, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants