Skip to content

Make make clean honor $(package). #4924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fisx wants to merge 3 commits into
base: develop
Choose a base branch
from
+5 −0
Open

Make make clean honor $(package). #4924

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2d32c
Make `make clean` honor $(package).
fisx Jan 2, 2026
938e4fe
replace 'echo' with 'rm'; use `if` instead of swallowing errors.
fisx Jan 2, 2026
5c55ab4
rm debug printf
fisx Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ full-clean: clean

.PHONY: clean
clean:
ifeq ("$(package)", "all")
Copy link
Contributor

@supersven supersven Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be good to keep the old behaviour as well? I.e. that make clean, cleans everything? Otherwise, people have to type more and learn about this change...

Copy link
Contributor Author

@fisx fisx Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"all" is the default, no need to type anything extra.

Copy link
Contributor

@supersven supersven Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now for the boring stuff: It might be good to document this, somewhere 😅

cabal clean
else
-if ( test -e dist || test -e dist-newstyle ); then find dist* -type d -name '$(package)-*' -exec rm -rf {}; fi
endif
# `/dist` shouldn't be created or used by anybody any more, we're just making sure here.
-rm -rf dist
-rm -f "bill-of-materials.$(HELM_SEMVER).json"

Expand Down