Generalize PATCH for scim user groups #4885
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
blackheaven
previously approved these changes
Dec 19, 2025
fisx
force-pushed
the
WPB-21817-patch-scim-groups
branch
6 times, most recently
from
c09f086 to
5e85dd5
Compare
fisx
force-pushed
the
WPB-21817-patch-scim-groups
branch
from
5e85dd5 to
17ba26f
Compare
fisx
force-pushed
the
WPB-21817-patch-scim-groups
branch
from
17ba26f to
b30491b
Compare
The old class `Patchable` mixes concerns of validation and patch application. We take this apart into - validate schemas based on aeson-schema - compile patch into aeson-diff syntax and apply that instead of implementing our own code for that Also Patchable is restricted to `User`, and the new code allows for patching Users, Groups, extension schemas, and potentially other stuff. In detail, the following changes are made in this commit: - `PatchOp` makes more illegal states unrepresentable with `PatchOp` instead of `Operation`; - `Web.Scim.Filter` is used, not re-invented; - replace `Patchable` class with `SupportsSchemas`; - re-implement `applyPatch` based on these changes; - more haddocs.
fisx
force-pushed
the
WPB-21817-patch-scim-groups
branch
2 times, most recently
from
219749f to
0835db4
Compare
fisx
force-pushed
the
WPB-21817-patch-scim-groups
branch
from
0835db4 to
df012ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-21817 (part I)
Checklist
changelog.d