[DO NOT MERGE] user nofifications pulsar hs #4884
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
supersven
force-pushed
the
sventennie/user-nofifications_pulsar-hs
branch
from
6054e89 to
2acec31
Compare
Otherwisem, HLS goes insane... :/
We simply push both for now, RabbitMQ and Pulsar.
Keep them around for a while.
This gives us more insights about what't happening.
Such that they can be decoded on the other end.
This ist superfluous and would just make the rabbit explode.
Also, do not acknowledge messages outside of the originally receiving consumer context.
Create one when a client is registered. Attach to it when a WebSocket is opened. Do never unsubscribe as this deletes the subscription.
8080 already belongs to nginz in our local test env.
We could configure more. However, we can do that when we exactly know what.
We now also need to mock Pulsar.
It served no purpose anymore...
supersven
force-pushed
the
sventennie/user-nofifications_pulsar-hs
branch
from
37bda92 to
6527dcb
Compare
I suspect that the protobuf variant leads to crashes. Let's see if the Admin REST API works better.
Juggling two branches makes things just more difficult in the long run...
Consider pulsar-client-cpp to be (hopefully!) thread safe. To speed up further usage, create the Client once per app and re-use it whenever a client is needed.
supersven
force-pushed
the
sventennie/user-nofifications_pulsar-hs
branch
from
6c86b8c to
12aeec9
Compare
- Ensure that each client is only attached once at a time (subscriptions are exclusive). This is done by switching to a more primitive concurrency model. - Adjust the message format a bit - Ensure that clients have distinct ids
supersven
force-pushed
the
sventennie/user-nofifications_pulsar-hs
branch
from
12aeec9 to
8225fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exists for now only to provide docker images for Pulsar-related performance tests.
It's far from being a feature-complete replacement.
Ticket: https://wearezeta.atlassian.net/browse/WPB-21623
Checklist
changelog.d