-
Notifications
You must be signed in to change notification settings - Fork 24
feat: introduces API v14 to fetch new cells feature config - WPB-22364 #4052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces API v14 to fetch new cells feature config - WPB-22364 #4052
Conversation
Test Results 8 files 1 062 suites 9m 22s ⏱️ For more details on these failures, see this check. Results for commit 6aa6337. ♻️ This comment has been updated with latest results. |
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I've added a comment for a small change to do in the AWS client. Feel free to discuss.
WireMessaging/Sources/WireMessagingData/WireCells/NodesAPI/AWSClient.swift
Outdated
Show resolved
Hide resolved
wire-ios-data-model/Source/Model/FeatureConfig/Cells/Feature.CellsInternal.swift
Show resolved
Hide resolved
wire-ios-data-model/Source/Model/FeatureConfig/Cells/Feature.CellsInternal.swift
Outdated
Show resolved
Hide resolved
…//github.com/wireapp/wire-ios into feat/get-cells-backend-url-from-feature-config
…//github.com/wireapp/wire-ios into feat/get-cells-backend-url-from-feature-config
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
…//github.com/wireapp/wire-ios into feat/get-cells-backend-url-from-feature-config
Issue
This PR introduces API v14 which is required to fetch wire cells backend URL from a newly introduced feature config.
A key change in this PR is to resolve the cells server URL dynamically since we now get its value after pulling all the resources during initial sync.
To avoid dealing with optionals in many parts of the codebase and keep the structure as close as it is currently, the solution was to inject a URL resolver closure in the factory which will be invoked at runtime by the
RestAPIand theAWSClient.Note: at the time of this PR, API v14 is still under development
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: