Use Route attributes for controller #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using Route attributes for the auth controller, and move the SshCommand's name to a constructor controller instead of the defaultName value. Drop testing on PHP 7.4. Bug: T361554
Member
Author
|
@AS1100K Would you be interested at looking at this patch? It'd help us get wscontest upgraded. |
AS1100K
reviewed
Nov 30, 2024
AS1100K
left a comment
AS1100K
left a comment
There was a problem hiding this comment.
Everything looks good to me. I also tested it locally on PHP version 8.2 with wscontest and everything seems to work.
Although, we need to update README.md to let other developers know that now this bundle supports symfony 7 which was meant to be done at 8a9ce57.
Member
Author
|
Good point! I'll update the readme. I guess we should also drop support for Symfony 4 (I mean, I think this change means we no longer support Symfony 4). |
Member
Author
|
After this, I'll update the skeleton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T361554