Skip to content

Memoize the key of instance_variable_set #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ooooooo-q wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Memoize the key of instance_variable_set #411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/rubyXL/objects/ooxml_object.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,11 +224,17 @@ def obtain_class_variable(var_name, default = {})
end
private :obtain_class_variable

@@_variable_keys = {}
def initialize(params = {})
@local_namespaces = nil

obtain_class_variable(:@@ooxml_attributes).each_value { |v|
instance_variable_set("@#{v[:accessor]}", params[v[:accessor]]) unless v[:computed]
unless v[:computed]
unless @@_variable_keys[v[:accessor]]
@@_variable_keys[v[:accessor]] = "@#{v[:accessor]}".freeze
end
instance_variable_set(@@_variable_keys[v[:accessor]], params[v[:accessor]])
end
}

init_child_nodes(params)
Expand All @@ -243,7 +249,10 @@ def init_child_nodes(params)
else nil
end

instance_variable_set("@#{v[:accessor]}", initial_value)
unless @@_variable_keys[v[:accessor]]
@@_variable_keys[v[:accessor]] = "@#{v[:accessor]}".freeze
end
instance_variable_set(@@_variable_keys[v[:accessor]], initial_value)
}
end
private :init_child_nodes
Expand Down