Closed
Conversation
laodaniel
force-pushed
the
force-json-parsing
branch
from
dcda582 to
cd6f718
Compare
jorgevillalta
approved these changes
Apr 24, 2025
selugr
approved these changes
Apr 24, 2025
joaquin-alonso
approved these changes
Apr 24, 2025
Contributor
Author
|
I won't merge this workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to https://github.com/weekendesk/tech-management/issues/1507
Scope
Before version 2.0.0 we were using the deprecated library request.
This library includes an option
jsonset by default which parses the response body as JSON.We have some API endpoints with incorrect
content-typewhich returns JSON as text in the body.As a workaround we want to force the json parsing if the request header contains
application/json.This behaviour is the same than version <2.0.0.