Skip to content

Conversation

@SomeBody16
Copy link
Contributor

@SomeBody16 SomeBody16 commented Nov 3, 2025

  • Implemented isCapableOfReceivingVideoCodec method to determine the presence of H.264 and AV1 codecs, respectively.
  • Added unit test to validate their functionality.

@SomeBody16 SomeBody16 mentioned this pull request Nov 3, 2025
19 tasks
@szotrabh szotrabh requested a review from antsukanova November 3, 2025 13:05
@szotrabh szotrabh self-requested a review November 3, 2025 15:44
@bbaldino
Copy link

bbaldino commented Nov 3, 2025

Will take a look at the code, but I'm not sure about putting this in web-capabilities. I think the original intent with web-capabilities was more browser API support type stuff, as opposed to media-level/SDP negotiation like this. Like, I don't think we'd put check for things like "mid-rid" or "simulcast" in here, and codec-level stuff to me feels like it's on the level of stuff like that, as opposed to things like "is some w3c api supported"

@SomeBody16
Copy link
Contributor Author

@bbaldino

Will take a look at the code, but I'm not sure about putting this in web-capabilities. I think the original intent with web-capabilities was more browser API support type stuff, as opposed to media-level/SDP negotiation like this. Like, I don't think we'd put check for things like "mid-rid" or "simulcast" in here, and codec-level stuff to me feels like it's on the level of stuff like that, as opposed to things like "is some w3c api supported"

If WebCapabilities class is for w3c apis then maybe new class for CodecInfo that can tell us info about current browser codecs like BrowserInfo tells us about current browser

5452bbe (#14) (something like this but with better implementation)

@edvujic edvujic changed the title feat: add CodecInfo class with methods to check codec availability feat: add isCapableOfReceivingVideoCodec Nov 6, 2025
@edvujic edvujic requested a review from antsukanova November 6, 2025 10:08
@edvujic edvujic requested a review from antsukanova November 6, 2025 10:19
Copy link
Contributor

@antsukanova antsukanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edvujic edvujic merged commit 3af6768 into webex:main Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants