Skip to content

Conversation

@0ax1
Copy link
Contributor

@0ax1 0ax1 commented Jan 21, 2026

No description provided.

@0ax1 0ax1 marked this pull request as ready for review January 21, 2026 17:06
@0ax1 0ax1 added the changelog/performance A performance improvement label Jan 21, 2026
@0ax1 0ax1 marked this pull request as draft January 21, 2026 21:05
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will degrade performance by 31.44%

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 1247 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation canonical_into_non_nullable[(10000, 10, 0.01)] 219.7 µs 308.6 µs -28.82%
Simulation canonical_into_non_nullable[(10000, 1, 0.01)] 44.4 µs 37.1 µs +19.5%
Simulation canonical_into_non_nullable[(10000, 1, 0.1)] 59.4 µs 53.2 µs +11.61%
Simulation canonical_into_non_nullable[(10000, 10, 0.0)] 192.9 µs 281.4 µs -31.44%
Simulation canonical_into_non_nullable[(10000, 1, 0.0)] 38.9 µs 31.8 µs +22.45%
Simulation canonical_into_non_nullable[(10000, 10, 0.1)] 375.4 µs 468 µs -19.78%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 5.1 ms 4.1 ms +24.85%

Comparing ad/async-copy (afbc61c) with develop (1a0d672)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@0ax1 0ax1 marked this pull request as ready for review January 22, 2026 11:38
@0ax1 0ax1 requested a review from joseph-isaacs January 22, 2026 12:10
@0ax1 0ax1 changed the title perf: async to host copy perf: CUDA async to host copy Jan 22, 2026
@0ax1 0ax1 added the ext/cuda Relates to the CUDA integration label Jan 22, 2026
0ax1 added 2 commits January 22, 2026 12:20
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1 0ax1 requested a review from joseph-isaacs January 22, 2026 13:45
@0ax1 0ax1 merged commit 05120e8 into develop Jan 22, 2026
45 of 47 checks passed
@0ax1 0ax1 deleted the ad/async-copy branch January 22, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/performance A performance improvement ext/cuda Relates to the CUDA integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants