Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 21, 2026

Pandas released a new version which broke the docs for us for python reasons, but this pulls a specific version.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested a review from robert3005 January 21, 2026 16:05
@AdamGS AdamGS added the changelog/fix A bug fix label Jan 21, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will degrade performance by 16.5%

Comparing adamg/unblock-ci-python-docs (22d0947) with develop (e5649fc)

Summary

⚡ 7 improved benchmarks
❌ 2 regressed benchmarks
✅ 1245 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.9 ms 2.1 ms +37.72%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 4.5 ms 3.7 ms +22.18%
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +42.36%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.1 ms 4.9 ms -16.5%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 444.9 µs 529.3 µs -15.96%
Simulation into_canonical_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +42.13%
Simulation into_canonical_non_nullable[(10000, 100, 0.1)] 4.6 ms 3.7 ms +21.6%
Simulation into_canonical_non_nullable[(10000, 100, 0.01)] 3 ms 2.2 ms +36.99%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 5.2 ms 4.4 ms +18.61%

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@joseph-isaacs joseph-isaacs merged commit 2b36b2e into develop Jan 21, 2026
42 of 44 checks passed
@joseph-isaacs joseph-isaacs deleted the adamg/unblock-ci-python-docs branch January 21, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants