Remove the python feature from vortex-error #6064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
force-pushed
the
adamg/remove-python-error-feature
branch
from
1ac3c1c to
ac3d92d
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
AdamGS
force-pushed
the
adamg/remove-python-error-feature
branch
from
ac3d92d to
46c19a5
Compare
AdamGS
changed the title
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
gatesn
reviewed
Jan 21, 2026
| impl PyStructArray { | ||
| /// Returns the given field of the struct array. | ||
| pub fn field(self_: PyRef<'_, Self>, name: &str) -> PyResult<PyArrayRef> { | ||
| pub fn field(self_: PyRef<'_, Self>, name: &str) -> Result<PyArrayRef, PyVortexError> { |
Contributor
There was a problem hiding this comment.
Can you type alias a PyVortexResult
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Contributor
Author
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a feature just for an error type, we introduce a new error type that helps us localize the functionality into
vortex-python, similarly to thePyVortextype.Like #6059, this should also help with CI and simplify our internal dependency matrix.