Skip to content

Conversation

@AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Jan 19, 2026

This PR allows using non object-store based readers when working with the Vortex FileSource, like when users want custom caching, observability or anything else.

@AdamGS AdamGS requested review from a10y and joseph-isaacs January 19, 2026 14:38
@AdamGS AdamGS added the feature Release label indicating a new feature or request label Jan 19, 2026
@AdamGS AdamGS force-pushed the adamg/df-io-plugin2 branch 2 times, most recently from 04ce2a4 to b1d420e Compare January 19, 2026 14:39
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 1254 untouched benchmarks
⏩ 1254 skipped benchmarks1


Comparing adamg/df-io-plugin2 (c53838f) with develop (edeef00)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.91%. Comparing base (b7a7027) to head (d946f03).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
vortex-datafusion/src/persistent/source.rs 46.15% 7 Missing ⚠️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/df-io-plugin2 branch from d946f03 to c53838f Compare January 21, 2026 14:31
@AdamGS AdamGS enabled auto-merge (squash) January 21, 2026 14:31
@AdamGS AdamGS merged commit e5649fc into develop Jan 21, 2026
42 of 44 checks passed
@AdamGS AdamGS deleted the adamg/df-io-plugin2 branch January 21, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Release label indicating a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants