Skip to content

New package: shattered-pixel-dungeon-3.3.1 #51361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MIvanchev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

New package: shattered-pixel-dungeon-3.3.1 #51361

MIvanchev wants to merge 1 commit into from

Conversation

@MIvanchev
Copy link
Contributor

@MIvanchev MIvanchev commented Jul 21, 2024

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (X86_64-GLIBC)

@classabbyamp classabbyamp added the new-package This PR adds a new package label Jul 21, 2024
@github-actions
Copy link

github-actions bot commented Oct 20, 2024

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Oct 20, 2024
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Oct 20, 2024

Bump.

@github-actions github-actions bot removed the Stale label Oct 21, 2024
@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-2.4.2 New package: shattered-pixel-dungeon-2.5.4 Dec 23, 2024
@github-actions
Copy link

github-actions bot commented Mar 24, 2025

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Mar 24, 2025
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Mar 25, 2025

Bump.

@github-actions github-actions bot removed the Stale label Mar 26, 2025
@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-2.5.4 New package: shattered-pixel-dungeon-3.0.2 Apr 2, 2025
@vincele
Copy link
Contributor

vincele commented Jun 9, 2025

I tried to build this locally just the branch as-is and then following a first failure, after having it rebased on upstream/master, which also failed, launching gradle.

* What went wrong:
Unable to start the daemon process.

This is on x86_64-musl.

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Jun 9, 2025

Hey @vincele , I play this daily, will try to fix it for you.

@MIvanchev MIvanchev force-pushed the ci-pixel branch 2 times, most recently from 0d87fb7 to cbc518f Compare June 9, 2025 19:04
@vincele
Copy link
Contributor

vincele commented Jun 9, 2025 •
edited
Loading

Thanks, it looks like all the *-musl failed, we may have a pattern there...
Those are the same that I got locally, and that is probably not related to SPD, but more to gradle & musl...
java.lang.ClassLoader$NativeLibrary.loadLibrary looks awfully like a JNI thing, so this may be the same kind of brokenness than for your mindustry PR #52749...

@MIvanchev MIvanchev force-pushed the ci-pixel branch 2 times, most recently from ab73b57 to e6cd735 Compare June 9, 2025 19:49
@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-3.0.2 New package: shattered-pixel-dungeon-3.1.0 Jun 9, 2025
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Jun 9, 2025

@vincele it could be that yesterday's update to gradle broke something...

@MIvanchev MIvanchev mentioned this pull request Jun 10, 2025
Merged
@Bnyro
Copy link
Contributor

Bnyro commented Jun 10, 2025

@vincele it could be that yesterday's update to gradle broke something...

Have you tried compiling it with an older version of Gradle?

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Jun 10, 2025

@Bnyro no but I just tried rebuilding Apktool and it failed in the same manner https://github.com/MIvanchev/void-packages/actions/runs/15559312968/job/43807446320 and I bet all other gradle projects do as well. I suggest reverting to the last known good version.

@Bnyro Bnyro mentioned this pull request Jun 10, 2025
Merged
@Bnyro
Copy link
Contributor

Bnyro commented Jun 10, 2025

Related upstream issues: gradle/gradle#32262 and gradle/gradle#31939.

I'm not really sure how we could patch this (and upstream doesn't have a patch yet either), so the best thing is probably just to subscribe to the linked issues and wait...

I've sent a PR to downgrade gradle: #55710.

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Jun 11, 2025

Great research @Bnyro, one would think that Gradle would test more before releasing stuff...

vincele
vincele approved these changes Jun 15, 2025
View reviewed changes
Copy link
Contributor

@vincele vincele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also tested working on x86_64-musl

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Jun 15, 2025

Have fun playing @vincele, it's an awesome game :)

@vincele
Copy link
Contributor

vincele commented Jun 15, 2025

Yeah, not a big player, but I knew this game from its android version, so this was interesting to see how it plays on a big screen...

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Sep 14, 2025
@vincele
Copy link
Contributor

vincele commented Sep 14, 2025 •
edited
Loading

I play semi-regularly, a five minutes game that ends very quickly as this game is hard. But it's entertaining enough... So I think this can go in (because it is working OK).

@MIvanchev
Copy link
Contributor Author

MIvanchev commented Sep 14, 2025

Bump.

@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-3.1.0 New package: shattered-pixel-dungeon-3.2.3 Sep 14, 2025
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Sep 14, 2025

@vincele Updated to 3.2.3 have fun!

@github-actions github-actions bot removed the Stale label Sep 15, 2025
@zen0bit
Copy link
Contributor

zen0bit commented Oct 11, 2025

3.2.5 is out
Simple autobump works...

@MIvanchev MIvanchev force-pushed the ci-pixel branch 2 times, most recently from a45c3e0 to 84ab677 Compare October 16, 2025 16:51
@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-3.2.3 New package: shattered-pixel-dungeon-3.2.5 Oct 16, 2025
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Oct 16, 2025

Fellas enjoy!

@zen0bit
Copy link
Contributor

zen0bit commented Dec 25, 2025

3.3.1 is out
needs openJDK17

@MIvanchev MIvanchev changed the title New package: shattered-pixel-dungeon-3.2.5 New package: shattered-pixel-dungeon-3.3.1 Dec 25, 2025
@MIvanchev
Copy link
Contributor Author

MIvanchev commented Dec 25, 2025

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@vincele vincele vincele approved these changes

@zen0bit zen0bit zen0bit approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

new-package This PR adds a new package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MIvanchev @vincele @Bnyro @zen0bit @classabbyamp