Open
Conversation
1323259 to
7f5dbe1
Compare
Member
|
Hey! 👋 require('/node_modules/react')
// ↓↓↓↓ convert ↓↓↓↓
import '/node_modules/react' |
Author
|
Hello 👋 Yep, in a project dependency I have no control of :( My project architecture is not that simple : Without the patch : Project C is able to load/work with 'node_modules/react' (webpack / conf magic ?) Project B can only be started/tested via StoryBook. In that environnement, StoryBook fails to load "node_modules/react". I found easier to work with your plugin :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @yejimeiming
While converting my project packager to Vite, I encountered some issues with a CJS dependency declaring its imports with "/node_modules/..."
Example : require("/node_modules/react")
Even with your plugin, it causes some issues and I couldn't find any other options or solutions (like aliases...) other than customizing your plugin.
This MR adds a "namingRules" advanced option (function), allowing to customize any detected import to a proper value).
I hope you'll find it useful/usable and include it in your plugin.
Feel free to contact me ²for any information
PS : Sorry if my TS code is imperfect (I'm used to JS :D )