Several fixes : Changing VIP portal / Girder URL, working route to check api key, check for empty file #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axlbonnet
requested changes
Feb 18, 2025
axlbonnet
reviewed
Feb 25, 2025
src/vip_client/utils/vip.py
Outdated
| # API URL | ||
| __PREFIX = "https://vip.creatis.insa-lyon.fr/rest/" | ||
|
|
||
| def set_vip_api_url(new_prefix: str) -> None: |
Collaborator
There was a problem hiding this comment.
change method name to set_vip_url and argument to vip_portal_url
| # Function to assert file existence in the input settings | ||
| @classmethod | ||
| def _first_missing_file(cls, value, location: str) -> str: | ||
| def _missing_file(cls, value, location: str) -> list[str]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.