make month width and height editable via props#19
Open
raphaelpinel wants to merge 2 commits intovinodkumar8:masterfrom
Open
make month width and height editable via props#19raphaelpinel wants to merge 2 commits intovinodkumar8:masterfrom
raphaelpinel wants to merge 2 commits intovinodkumar8:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love this project and I've been trying to implement it with a Finnish locale which have quite long 'short' months names. I tries to adjust the width via styling in props but didn't manage. Disabled Month behaved differently and the selected Month's circle was not aligned any more. I figured out there was one simple property, the width (and height + borderRadius set to its half) that allows automatically to make more space without changing any other styling. This makes it available via props.