Feature create event #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create fabricator for event model
* Preventing increasing of the test database
* Also use the thin gem to use instead of webrick in development
Conflicts: Gemfile
spec/fabricators/user_fabricator.rb
Outdated
| @@ -0,0 +1,6 @@ | |||
| Fabricator :user do | |||
| email { sequence { |n| "user_#{n}@hackdmx.com" } } | |||
Contributor
There was a problem hiding this comment.
Always use *@example.com dummy email addresses. That's the first step to avoid sending emails to actual email addresses when testing.
Author
There was a problem hiding this comment.
I'm not sure because in that case it will send emails to *@example.com, and that domain actually exist and we don't control it, in my opinion it would be a better idea to use a domain that we do control.
Contributor
There was a problem hiding this comment.
Seriously, example.com is a special and reserved domain, see this
app/controllers/events_controller.rb
Outdated
|
|
||
| def update | ||
|
|
||
| find_event |
Contributor
There was a problem hiding this comment.
Y U NO use a before_action ?
Conflicts: app/models/user.rb config/routes.rb
… feature_create_event Conflicts: db/schema.rb
Conflicts: Gemfile Gemfile.lock
| redirect_to events_path | ||
| else | ||
| flash[:error] = 'Something went wrong' | ||
| render new_event_path |
Contributor
There was a problem hiding this comment.
At line 37 you use render action: 'edit' and here you use a path helper. Isn't this somewhat inconsistent?
* Avoiding redundancy * Using the path helper is breaking the test
Owner
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.