Skip to content

Conversation

@hexbabe
Copy link
Member

@hexbabe hexbabe commented Aug 25, 2025

This PR is part of the SDK changes of the Consolidate GetImage(s) project

It

  • Updates the GetImages signature to be in line with the new camera.proto
  • Changes mime type handling to new string paradigm rather than explicit mime type enums. We should continue supporting known enums, but this change will allow users to pass through unsupported enums without losing information.
  • Updates unit tests

Manual Testing

See comments below

@hexbabe hexbabe requested a review from a team as a code owner August 25, 2025 15:05
@hexbabe hexbabe requested review from lia-viam and stuqdog August 25, 2025 15:05
@github-actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
button push
genericcomponent do_command
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
switch get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
power_sensor get_power
motion get_pose
vision get_properties
mlmodel metadata
genericservice do_command
slam get_point_cloud_map

@hexbabe hexbabe requested a review from njooma August 25, 2025 15:15
@hexbabe hexbabe force-pushed the RSDK-11704-and-RSDK-11603 branch 2 times, most recently from e756726 to dc6b22f Compare August 25, 2025 17:32
@hexbabe hexbabe force-pushed the RSDK-11704-and-RSDK-11603 branch 5 times, most recently from 593d0ae to 2b52c16 Compare August 25, 2025 20:40
@hexbabe hexbabe force-pushed the RSDK-11704-and-RSDK-11603 branch from 2b52c16 to e8cd337 Compare August 25, 2025 20:40
@hexbabe hexbabe marked this pull request as draft August 25, 2025 20:42
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me! I'm curious though what manual testing will be necessary here, if any.

@hexbabe
Copy link
Member Author

hexbabe commented Aug 26, 2025

looks reasonable to me! I'm curious though what manual testing will be necessary here, if any.

So far I've tested with a Python client that depends on a wheel I built from this feature branch code. Verified filter_source_names works.

@hexbabe
Copy link
Member Author

hexbabe commented Aug 26, 2025

verified Python client and server working with these new changes! Upgraded python camera oak module to feature branch wheel and verified filter source names and extra were received and handled properly.

2025-08-26T18:36:36.005Z        INFO    oak-d-1 oak.py:330      get_images called       {"log_ts":"2025-08-26T14:36:36.004Z"}
2025-08-26T18:36:36.005Z        INFO    oak-d-1 oak.py:334      filter_source_names: ['depth']  {"log_ts":"2025-08-26T14:36:36.004Z"}
2025-08-26T18:36:36.005Z        INFO    oak-d-1 oak.py:335      extra: {'foo': 'bar`'}  {"log_ts":"2025-08-26T14:36:36.004Z"}

@hexbabe hexbabe marked this pull request as ready for review August 26, 2025 18:37
@hexbabe hexbabe merged commit 217af75 into viamrobotics:main Aug 27, 2025
13 checks passed
@hexbabe hexbabe deleted the RSDK-11704-and-RSDK-11603 branch August 27, 2025 03:14
stuqdog added a commit to stuqdog/python-sdk that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants