-
Notifications
You must be signed in to change notification settings - Fork 67
[RSDK-11704, RSDK-11603] Update Python SDK with new GetImages signature #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
e756726 to
dc6b22f
Compare
593d0ae to
2b52c16
Compare
2b52c16 to
e8cd337
Compare
stuqdog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable to me! I'm curious though what manual testing will be necessary here, if any.
So far I've tested with a Python client that depends on a wheel I built from this feature branch code. Verified |
|
verified Python client and server working with these new changes! Upgraded python camera oak module to feature branch wheel and verified filter source names and extra were received and handled properly. |
… signature (viamrobotics#982)" This reverts commit 217af75.
This PR is part of the SDK changes of the Consolidate GetImage(s) project
It
Manual Testing
See comments below