[APP-14658] Fragment Imports #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgritter
added
ready-for-protos
github-actions
bot
added
safe to test
tgritter
commented
Dec 19, 2025
|
|
||
| message FragmentImports { | ||
| string fragment_id = 1; | ||
| string version = 2; // revision or tag |
Member
Author
There was a problem hiding this comment.
We could make this optional and just default to the latest if it is not present. But probably doesn't hurt to force the client to make it explicit.
tgritter
changed the title
tgritter
added
ready-for-protos
petrnovikov
reviewed
Dec 19, 2025
proto/viam/app/v1/app.proto
Outdated
| optional string version = 5; // revision or tag | ||
| } | ||
|
|
||
| message FragmentImports { |
Member
There was a problem hiding this comment.
Probably a nit, but shouldn't this be FragmentImport singular?
petrnovikov
approved these changes
Dec 19, 2025
Member
petrnovikov
left a comment
petrnovikov
left a comment
There was a problem hiding this comment.
Left one comment, otherwise LGTM!
tgritter
added
ready-for-protos
tgritter
added
ready-for-protos
tgritter
added
ready-for-protos
proto, adds it as optional field to UpdateOrganizationRequest
tgritter
force-pushed
the
APP-14658/fragment-imports
branch
from
0c9a4f6 to
ed5bd16
Compare
tgritter
added
ready-for-protos
tgritter
force-pushed
the
APP-14658/fragment-imports
branch
from
07601ec to
ed5bd16
Compare
tgritter
added
ready-for-protos
jgeaso1266
pushed a commit
to jgeaso1266/api
that referenced
this pull request
Dec 25, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
FragmentImportsmessage and adds support for organization-level default fragments. Organizations can now define a list of default fragments that will be automatically applied across all machines in the organization.Changes
FragmentImports- defines fragment import configuration with support for:fragment_id- the fragment to importversion-required revision or tag to pin to a specific fragment versionprefix- optional namespace prefix to avoid resource name collisionsvariables- optional key-value pairs for fragment variable substitutionUpdateOrganizationRequest- addedrepeated FragmentImports fragment_importsfield to allow setting organization-level default fragmentsTechnical Details
Links