Fixes invoice table re-ordering results on render and pagination due to order being random#531
Open
esadler44 wants to merge 2 commits intovercel:mainfrom
Open
Fixes invoice table re-ordering results on render and pagination due to order being random#531esadler44 wants to merge 2 commits intovercel:mainfrom
esadler44 wants to merge 2 commits intovercel:mainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@esadler44 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
This fixes the issue of random order but breaks chapter 12 "You should see the new invoice at the top of the table." since the id is an auto-generated string. I believe that this part of the code should be changed so it also includes time in the DB: |
|
After some investigation, I believe that here it should be: and for creating the schema we could utilize this: The idea is to store the time too. So you would be doing something like this: WDYT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unique value to the ORDER BY statement so that SQL behaves in a stable manner
This was causing unstable issues with pagination repeating data as you might get the same invoices on multiple pages with a non-unique ordering