Skip to content

Allow ValueError to pass-through without exception conversion. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EliRibble wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow ValueError to pass-through without exception conversion. #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions commentjson/commentjson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,10 @@ def load(fp, **kwargs):

try:
return loads(fp.read(), **kwargs)
except ValueError:
# pass through ValueError since that likely just indicates a bad
# JSON file and ValueError is how the json library signals that.
raise
except Exception as e:
raise JSONLibraryException(e)

Expand Down