Removing event listener (resize and keydown) component will unmount#43
Open
marcolongitude wants to merge 7 commits intov0ltoz:masterfrom
Open
Removing event listener (resize and keydown) component will unmount#43marcolongitude wants to merge 7 commits intov0ltoz:masterfrom
marcolongitude wants to merge 7 commits intov0ltoz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When leaving the screen where the datepicker component is rendered and resizing the browser window, the resize and keydown events were still active exposing errors in the browser console: it is not possible to find the node in a disassembled component. The componentWillUnmount function was implemented to reset the resize and keydown events.