-
Notifications
You must be signed in to change notification settings - Fork 848
pdf-decorating:0.1.0 and pdf-decoration:0.1.0 #3744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
saecki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this package! I've left a couple of comments regarding the name and license.
| version = "0.1.0" | ||
| entrypoint = "lib.typ" | ||
| authors = ["HackYardo <https://github.com/hackyardo>"] | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you either include a LICENSE file or add a section in the readme? See https://github.com/typst/packages/blob/main/docs/licensing.md
| @@ -0,0 +1,10 @@ | |||
| [package] | |||
| name = "pdf-decoration" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package name is a little too general. We try to avoid canonical names, so multiple packages with the same purpose can coexist without any unfair advantages. See https://github.com/typst/packages/blob/main/docs/manifest.md#naming-rules
|
Sorry for wrong path and files. Please wait for a while... |
|
Sure, no problem :) |
I am submitting
Description: To beautify and clarify PDF via Web visuals
Why: The Web field develops fast, and websites become more and more beautiful and clear. Many visuals can be introdeced into PDF.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfile or linked one in myREADME.mdexcluded PDFs or README images, if any, but not the LICENSE