Open
Conversation
…ed references in code as necessary
…caped SQL values as SqlSanitized.
SQL tainting qualifiers and basic tests
…and SqlSanitizedUser
…bined SqlQuoteless and SqlEvenQuotes; revised documentations
mernst
requested changes
Jun 6, 2025
Member
mernst
left a comment
mernst
left a comment
There was a problem hiding this comment.
I have just a couple last comments.
checker/src/main/java/org/checkerframework/checker/confidential/ConfidentialTransfer.java
Show resolved
Hide resolved
checker/src/main/java/org/checkerframework/checker/confidential/ConfidentialTransfer.java
Outdated
Show resolved
Hide resolved
# Conflicts: # checker/src/main/java/org/checkerframework/checker/confidential/ConfidentialTransfer.java
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new Confidential Checker to the Checker Framework that identifies sensitive information exposure (information leakage). The checker prevents confidential values from flowing to non-confidential locations, helping prevent security vulnerabilities like PII exposure in logs, UI elements, or other public-facing sinks.
Key changes:
- Implements a complete type system with
@Confidential,@NonConfidential,@UnknownConfidential, and related qualifiers - Adds extensive library annotations for logging frameworks (Log4j, SLF4J, Apache Commons), Android UI components, and Spring Security
- Includes comprehensive documentation and test cases
Reviewed Changes
Copilot reviewed 49 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| checker-qual/src/main/java/org/checkerframework/checker/confidential/qual/*.java | Core qualifier annotations defining the confidential type hierarchy |
| checker/src/main/java/org/checkerframework/checker/confidential/*.java | Main checker implementation with type factory, visitor, and transfer functions |
| checker/src/main/java/org/checkerframework/checker/confidential/*.astub | Library annotations for popular frameworks (Spring Security, logging libraries, Android) |
| docs/manual/confidential-checker.tex | Complete documentation chapter explaining the checker's purpose and usage |
| framework/tests/all-systems/*.java | Test files with @SuppressWarnings annotations for confidential checker warnings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated with JDK pull request #224