Issue error if top is used in a contract annotation#6429
Open
mernst wants to merge 7 commits intotypetools:masterfrom
Open
Issue error if top is used in a contract annotation#6429mernst wants to merge 7 commits intotypetools:masterfrom
mernst wants to merge 7 commits intotypetools:masterfrom
Conversation
smillst
requested changes
Jan 30, 2024
Member
smillst
left a comment
smillst
left a comment
There was a problem hiding this comment.
I still don't think these changes are right. I propose that I take over this pull request and make the changes I want.
| } | ||
| } | ||
|
|
||
| // Check for type-system specific annotations. These are the annotations that are |
Member
There was a problem hiding this comment.
It's strange that this code is reading the meta-annotations every time it encounters a declaration annotation rather than just when the checker is initialized. I want to rewrite this.
| String methodString = " on method " + executableElement.getSimpleName(); | ||
| factory | ||
| .getChecker() | ||
| .reportWarning( |
Member
There was a problem hiding this comment.
Warnings should only be issued in the BaseTypeVisitor. Specifically, this code belongs in BaseTypeVisitor#checkContractsAtMethodDeclaration.
Member
Author
|
OK, you can take over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge atter #6432.