fix(Topic): Fix race condition on racing subscribe and close #3662
+100
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption and closing of a Topic.
TomasMikula
commented
Jan 14, 2026
|
|
||
| Resource.eval(signalClosure.tryGet).flatMap { | ||
| case Some(_) => Resource.pure(Stream.empty) | ||
| case None => |
Author
There was a problem hiding this comment.
Here's the original race condition: signalClosure.tryGet returns None, but by the time we subscribe the Topic might have been closed and subscription Stream never terminates.
Fixed by making the state Ref able to determine closure. I.e., check and update a single Ref, instead of checking a Deferred and updating a Ref.
TomasMikula
force-pushed
the
fix-issue-3642
branch
from
7766643 to
3f7cbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3642: non-terminating subscription stream on race condition between
Topic'ssubscribeandclose.Builds on PR #3643 (failing test).