This repository was archived by the owner on Jan 20, 2022. It is now read-only.
Make mergeBatched protected instead of private.#764
Open
non wants to merge 1 commit intotwitter:developfrom
Open
Make mergeBatched protected instead of private.#764non wants to merge 1 commit intotwitter:developfrom
non wants to merge 1 commit intotwitter:developfrom
Conversation
There are reasons why particular implementations might want to override this method (for example, to support custom serialization strategies), so let's make it protected instead of private.
Collaborator
|
👍 Thanks! merge when green. |
Collaborator
|
looks like this fails mima, naturally... So we can make the change at the next mima break, maybe when we release for scalding 0.18 |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are reasons why particular implementations might want to
override this method (for example, to support custom serialization
strategies), so let's make it protected instead of private.