Skip to content

Conversation

@manisha1997
Copy link
Contributor

Fixes

Reversing regional endpoint mapping.
Changing warning message

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 requested review from kridai and sbansla January 28, 2026 09:34
Remove comment indicating that the class should not be instantiated directly.
@sbansla
Copy link
Contributor

sbansla commented Jan 29, 2026

Improvement in existing functionality:
In the existing code, the default region is set to us1. The issue with this approach is that if a customer has only set the frankfurt edge location, the resulting URL will be: api.frankfurt.us1.twilio.com.
In this case, the backend ignores the edge location, and the request is processed in the us1 region.

If the default region is removed, the resulting URL will be: api.frankfurt.twilio.com However, this request will fail.

Idea of the change is: We can be very transparent in setting region and edge.

@sonarqubecloud
Copy link

@manisha1997 manisha1997 merged commit c3e9334 into main Feb 2, 2026
14 checks passed
@manisha1997 manisha1997 deleted the regional-edge-processing branch February 2, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants