fix c_char cast issue

[bguo068]

Fix #803

[molpopgen]

Thanks @bguo068 -- given that this PR is meant to address an architecture-specific issue, we also need the CI to be updated to run on the relevant architecture prior to any merging.

[bguo068]

Thanks @bguo068 -- given that this PR is meant to address an architecture-specific issue, we also need the CI to be updated to run on the relevant architecture prior to any merging.

Thanks for the comment @molpopgen . I am kind of new with GitHub Actions. Any suggestions on which of the workflow yaml files to look at? I am thinking about adding some item in the "matrix".

[molpopgen]

Thanks @bguo068 -- given that this PR is meant to address an architecture-specific issue, we also need the CI to be updated to run on the relevant architecture prior to any merging.

Thanks for the comment @molpopgen . I am kind of new with GitHub Actions. Any suggestions on which of the workflow yaml files to look at? I am thinking about adding some item in the "matrix".

workflows/tests.yml is the most important one. In theory you should just be able to add the right OS label to the os matrix. (You may have to update the matrix in a few places?)

[bguo068]

I added the ubuntu-24.04-arm OS to the matrix under the test-64bit job in test.yml but not to other jobs. Hopefully, that's sufficient. After adding this OS, there are a few more compiler errors related to the c_char cast issue which were also fixed. All changes have been squashed into a single commit. Please let me know if this is adequate. Thanks.

[molpopgen]

@bguo068 -- thanks for this. Would you mind editing the commit message to use conventional syntax? Something like:

fix: use c_char instead of i8 when handling C strings

This way changes will get into the correct part of the change log for the next release.

[bguo068]

Just did that. Thanks for sharing the link. It is a great reference.

[molpopgen]

Just did that. Thanks for sharing the link. It is a great reference.

I wish I'd discovered conventional commits years ago! They are a bit limiting, but sometimes that can be a good thing. It is certainly nice to have your change log auto-generated.