Skip to content

Conversation

@tschaefer
Copy link
Owner

No description provided.

@gitguardian
Copy link

gitguardian bot commented Dec 10, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
23270582 Triggered Username Password d98aead internal/manager/manager_test.go View secret
23270583 Triggered Generic High Entropy Secret d98aead internal/manager/manager_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the manager component to use context-based cancellation instead of internal signal handling, improving testability and separation of concerns. Signal handling is moved up to the command layer where it belongs.

  • Manager.Run() now accepts a context parameter for cancellation control
  • Signal handling logic moved from manager package to cmd/run package
  • Comprehensive test suite added for manager package covering success and error cases

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
internal/manager/manager.go Refactored Run() method to accept context parameter and removed signal handling logic
cmd/run/run.go Added signal.NotifyContext to handle SIGINT/SIGTERM and pass context to manager
internal/manager/manager_test.go Added comprehensive test coverage for manager initialization and Run() method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tschaefer tschaefer force-pushed the tschaefer/maintenance/manager-refactor-test branch from 495b22a to d98aead Compare December 10, 2025 16:02
@tschaefer tschaefer marked this pull request as ready for review December 10, 2025 16:24
@tschaefer tschaefer merged commit 3c0692a into main Dec 10, 2025
2 checks passed
@tschaefer tschaefer deleted the tschaefer/maintenance/manager-refactor-test branch December 10, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants