Fixing issue with non-ASCII characters in README.rst#23
Open
karthich wants to merge 1 commit intotravishathaway:masterfrom
Open
Fixing issue with non-ASCII characters in README.rst#23karthich wants to merge 1 commit intotravishathaway:masterfrom
karthich wants to merge 1 commit intotravishathaway:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to install python-ach module in a docker image, I get this error.
This is an issue with non-ASCII characters being in the README. We can fix this by using codecs.open('README.rst', encoding='utf-8').read() instead of open('README.rst').read() (the change is both python3 and python2 compatible).
Similar to this issue on urllib3:
urllib3/urllib3#823