Use ValueSource to run pod commands for CocoaPods publishing#278
Merged
KevinSchildhorn merged 2 commits intomainfrom Jan 23, 2025
Merged
Use ValueSource to run pod commands for CocoaPods publishing#278KevinSchildhorn merged 2 commits intomainfrom
KevinSchildhorn merged 2 commits intomainfrom
Conversation
samhill303
approved these changes
Jan 23, 2025
Contributor
samhill303
left a comment
There was a problem hiding this comment.
Not sure ValueSource is needed, but it's working and I don't mind a little more structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #267
Summary
Moving pod calls to use a ValueSource.
Fix
exitValueerror, we catch it and then throw the underlying errorTesting
./gradlew test./gradlew buildbefore
after