Skip to content

add handle operation toward rpc err in scan_inner#495

Open
BryceCao wants to merge 1 commit intotikv:masterfrom
BryceCao:wip-add-rpc-error-handler-for-scan
Open

add handle operation toward rpc err in scan_inner#495
BryceCao wants to merge 1 commit intotikv:masterfrom
BryceCao:wip-add-rpc-error-handler-for-scan

Conversation

@BryceCao
Copy link

@BryceCao BryceCao commented Jul 3, 2025 •
edited
Loading

fix #493

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zyguan for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2025

Welcome @BryceCao!

It looks like this is your first PR to tikv/client-rust 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to tikv/client-rust. 😃

@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2025
@BryceCao BryceCao force-pushed the wip-add-rpc-error-handler-for-scan branch from 988f660 to cee5486 Compare July 3, 2025 06:17
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Jul 3, 2025
@BryceCao BryceCao mentioned this pull request Jul 3, 2025
Open
pingyu
pingyu reviewed Jul 15, 2025
View reviewed changes
Copy link
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution !

Please fix the DCO error.

src/request/plan.rs Outdated
}
}

pub(crate) async fn handle_rpc_error<PdC: PdClient>(
Copy link
Collaborator

@pingyu pingyu Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to name as invalidate_cache for wider usage.

It would be nice if you can use this method for handle_region_error & handle_other_error to eliminate duplicated codes. But it is still OK if you do not want to change them in this PR.

Copy link
Author

@BryceCao BryceCao Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the method has been rename, but eliminating duplicated codes is hard to me, because invalidate_region_cache() and invalidate_store_cache() is used with so much if else branch.

@BryceCao BryceCao force-pushed the wip-add-rpc-error-handler-for-scan branch from 2401711 to d0a7eb9 Compare September 26, 2025 03:43
@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 26, 2025
@BryceCao
add handle operation toward rpc err in scan_inner
99ab90c 
fix: tikv#493
Signed-off-by: cao.leilc <cao.leilc@inspur.com>
@BryceCao BryceCao force-pushed the wip-add-rpc-error-handler-for-scan branch from d0a7eb9 to 99ab90c Compare September 26, 2025 03:57
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pingyu pingyu pingyu left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

“Connection refused ” caused by stopping tikv process when the tikv is marked as offline status

2 participants

@BryceCao @pingyu