Conversation
Signed-off-by: Smityz <smityz@qq.com>
|
This dev container config can compile on MacOS, but can't compile on Windows 11. I think it's a platform problem, I will fix it later. |
| /bin/bash -c "make release" | ||
| ``` | ||
|
|
||
| **Way3: Use Image to Compile(Image is NOT Official)** |
There was a problem hiding this comment.
No. It's better to start a proposal build an image with approval of TiKV committers or maintainers instead of recommend a personal docker image in README.
@Smityz you can still mention it in the PR description and spread among social media, but TiKV may not endorse it like this.
There was a problem hiding this comment.
Agree with you, and I will convert this PR to draft until someone builds an official docker image.
| @@ -0,0 +1,24 @@ | |||
| FROM centos:7.9.2009 | |||
There was a problem hiding this comment.
Based on my experience developing a dev container for OpenDAL, I recommend using mcr.microsoft.com/devcontainers/rust:bullseye and customizing it with post_create.sh. For more information, please visit https://github.com/apache/incubator-opendal/tree/main/.devcontainer.
- All images are cached so users don't need to fetch them.
- Those images are well-maintained and updated.
- Those images handles many suck things related to users permission which is not easy (we tried and failed at OpenDAL).
There was a problem hiding this comment.
Thank you, let me try
4 participants
related issue: #18
add a dev container config for client-cpp
Closes #18