ENG-505 [DRAFT] local development setup #3858
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new system to monitor various operations within the Keep Core node, including wallet actions, DKG processes, signing operations, coordination procedures, and network activities. - Metrics are recorded through a new interface, allowing for optional integration without impacting performance when disabled. - Updated relevant components to wire in metrics recording, ensuring comprehensive coverage of critical operations. - Added documentation detailing implemented metrics and their usage. This enhancement provides better visibility into node performance and health, facilitating monitoring and troubleshooting.
- Updated and to include new addresses for WalletRegistry, Bridge, MaintainerProxy, and WalletProposalValidator. - Introduced new JSON files for deposit data and funding transaction information to support deposit and redemption processes. - Added various scripts for managing DKG processes, wallet requests, and operator registration, enhancing local development capabilities. - Included documentation updates for deployment and operational guidelines. These changes improve the setup for Ethereum interactions and streamline the development workflow.
| @@ -0,0 +1,13 @@ | |||
| ========================================== | |||
Contributor
There was a problem hiding this comment.
This file seems like local dev output that shouldn't be in the repo.
|
|
||
| /** | ||
| * @title BridgeStub | ||
| * @notice Minimal stub implementation of Bridge contract for local development |
Contributor
There was a problem hiding this comment.
Might be worth adding a brief comment at the top explaining this is only for local dev/testing and should never be used in production, just to avoid any confusion downstream.
|
|
||
| [ethereum] | ||
| URL = "ws://127.0.0.1:8546" | ||
| KeyFile = "/Users/levakhnazarov/ethereum/data/keystore/UTC--2025-12-18T18-53-35.539381000Z--7966c178f466b060aaeb2b91e9149a5fb2ec9c53" |
Contributor
There was a problem hiding this comment.
This contains a hardcoded local path and timestamp. Consider using a placeholder like <YOUR_KEYFILE_PATH> or moving this to configs/config.toml.SAMPLE instead of committing it to the repo root.
| # DisseminationTime = 90 | ||
|
|
||
| [storage] | ||
| Dir = "/Users/levakhnazarov/threshold/fork2/keep-core/data" |
Contributor
There was a problem hiding this comment.
Same as above, hardcoded absolute path. Might want to use a relative path or environment variable placeholder.
lionakhnazarov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial setup for local T network development
genesis.jsonfor blockchain initialization with predefined accounts and balances.setup-geth.sh,generate-genesis.sh,check-deployments.sh,deploy-ecdsa-tbtc.sh) to facilitate local development and contract deployment.This commit lays the groundwork for developers to easily set up and interact with the T network in a local environment.