Expand FAQ with Dedicated Relayer FAQs #8585
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
github-actions
bot
added
the
Portal
WalkthroughRemoved the "Server Wallets" heading and added a new "Gas Sponsorship" section with multiple Details blocks (relayer plan/pricing, benchmarks, comparisons, scaling, TPS). Ecosystem Wallets remains; Gas Sponsorship placed before Security & Recoverability. No public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8585 +/- ##
=======================================
Coverage 53.19% 53.19%
=======================================
Files 922 922
Lines 61480 61480
Branches 4032 4032
=======================================
Hits 32706 32706
Misses 28676 28676
Partials 98 98
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
apps/portal/src/app/wallets/faq/page.mdx (1)
64-66: LGTM!The FAQ clearly explains the dedicated relayer is an add-on service and provides a helpful link to pricing information.
Optional: Consider consistent capitalization
For consistency, you might want to use either "Dedicated Relayer" (capitalized) or "dedicated relayer" (lowercase) throughout all the FAQ entries. Currently line 65 uses "Dedicated Relayer" while other entries use "dedicated relayer".
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/wallets/faq/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Build Packages
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/portal/src/app/wallets/faq/page.mdx (3)
62-63: LGTM!The section heading is clear and follows the same format as other sections in the FAQ.
82-86: LGTM!The FAQ clearly explains that scaling is managed and describes what aspects are handled by thirdweb (executor/chain configuration, infrastructure, and automatic funding).
88-90: LGTM!The FAQ provides a clear answer about TPS capacity with appropriate caveats about chain-specific factors. The benchmark of ~100 TPS with ten executors is helpful for users evaluating the service.
size-limit report 📦
|
saminacodes
added
the
merge-queue
Merge activity
|
Added information about gas sponsorship and dedicated relayer features.
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces new content related to `Gas Sponsorship` in the `page.mdx` file, adding FAQs about the dedicated relayer service offered by thirdweb.
### Detailed summary
- Added a new section titled `Gas Sponsorship`.
- Included multiple FAQs regarding the dedicated relayer:
- Its status as an add-on service.
- Expected performance benchmarks.
- Comparison to other alternatives.
- Management of scaling on multiple relayer instances.
- Transaction handling capacity.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Documentation**
* Expanded wallets FAQ with a new "Gas Sponsorship" section covering dedicated relayer plan/pricing, throughput benchmarks for single vs. multi-executor setups, comparisons with alternative queue approaches, scaling guidance for multiple relayer instances, and transaction-per-second expectations. Reordered content so Gas Sponsorship appears before Security & Recoverability; Ecosystem Wallets content retained.
<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
saminacodes-patch-1
branch
from
f44fd16 to
8bdc0c0
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)
apps/portal/src/app/wallets/faq/page.mdx (2)
68-72: Remove redundant phrase in line 71.Line 71 contains a redundant repetition: "with ten executors instead of one" appears twice in the same sentence, making it awkward to read.
🔎 Proposed fix
- The premium tier with ten executors instead of one will improve this by 10x with ten executors instead of one. + The premium tier with ten executors instead of one will improve this by 10x.
74-77: Fix missing article and clarify EIP reference.Line 77 is missing an article before "EIP-2771 relayer." Additionally, line 75 references "7702" which should be clarified as "EIP-7702" for consistency with standard Ethereum Improvement Proposal nomenclature.
🔎 Proposed fixes
- Our dedicated relayer gives you your very own queue. It is also built for 7702 - meaning both user and server wallets can use it without any code changes and msg.sender still remains as the user. + Our dedicated relayer gives you your very own queue. It is also built for EIP-7702 - meaning both user and server wallets can use it without any code changes and msg.sender still remains as the user. - This is in contrast with an EIP-2771 relayer which requires contract changes. + This is in contrast with an EIP-2771 relayer which requires contract changes.
🧹 Nitpick comments (1)
apps/portal/src/app/wallets/faq/page.mdx (1)
75-75: Simplify redundant phrasing.The phrase "still remains as" contains redundancy. Consider simplifying to either "remains" or "is still" for better readability.
🔎 Proposed fix
- Our dedicated relayer gives you your very own queue. It is also built for 7702 - meaning both user and server wallets can use it without any code changes and msg.sender still remains as the user. + Our dedicated relayer gives you your very own queue. It is also built for EIP-7702 - meaning both user and server wallets can use it without any code changes and msg.sender remains the user.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
apps/portal/src/app/wallets/faq/page.mdx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Build Packages
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/portal/src/app/wallets/faq/page.mdx (3)
62-63: LGTM!The section header follows the existing pattern and is appropriately placed in the FAQ structure.
64-66: LGTM!Clear explanation with appropriate reference to the pricing page.
82-90: LGTM!The scaling and TPS FAQs provide clear, practical information about the dedicated relayer service capabilities. The performance figures align with the earlier benchmark statements.
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
graphite-app
bot
removed
the
merge-queue
Added information about gas sponsorship and dedicated relayer features.
PR-Codex overview
This PR introduces a new section on
Gas Sponsorshipin thepage.mdxfile, providing detailed FAQs about the dedicated relayer service offered by thirdweb.Detailed summary
Gas Sponsorshipsection.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.